diff options
| author | Eric Wong <e@80x24.org> | 2019-01-01 13:03:08 +0000 |
|---|---|---|
| committer | June McEnroe <june@causal.agency> | 2022-02-13 11:55:52 -0500 |
| commit | a8e11db6570261d2a3d7d9396b796b72998b7ec5 (patch) | |
| tree | f8f37dcb98ef6f5eb6976223c06c9b59aeed329f /cgit.c | |
| parent | b2511f29548d12a26a321ad5be433d82c49b135f (diff) | |
| download | cgit-pink-a8e11db6570261d2a3d7d9396b796b72998b7ec5.tar.gz cgit-pink-a8e11db6570261d2a3d7d9396b796b72998b7ec5.zip | |
Use buffered stdio
Our generation of HTML triggers many small write(2) syscalls which is inefficient. Time output on a horrible query against my git.git mirror shows significant performance improvement: QUERY_STRING='id=2b93bfac0f5bcabbf60f174f4e7bfa9e318e64d5&id2=d6da71a9d16b8cf27f9d8f90692d3625c849cbc8' PATH_INFO=/mirrors/git.git/diff export QUERY_STRING PATH_INFO time ./cgit >/dev/null Before: real 0m1.585s user 0m0.904s sys 0m0.658s After: real 0m0.750s user 0m0.666s sys 0m0.076s
Diffstat (limited to 'cgit.c')
| -rw-r--r-- | cgit.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/cgit.c b/cgit.c index c4320f0..d8ea221 100644 --- a/cgit.c +++ b/cgit.c @@ -674,7 +674,7 @@ static inline void authenticate_post(void) len = MAX_AUTHENTICATION_POST_BYTES; if ((len = read(STDIN_FILENO, buffer, len)) < 0) die_errno("Could not read POST from stdin"); - if (write(STDOUT_FILENO, buffer, len) < 0) + if (fwrite(buffer, 1, len, stdout) < len) die_errno("Could not write POST to stdout"); cgit_close_filter(ctx.cfg.auth_filter); exit(0); |